Commit 9d07d24
docs(core): address review feedback on #744
- utils.setup_logging: update stale docstring to reflect the new log
path (``<basic-memory data dir>/basic-memory.log``, honors
BASIC_MEMORY_CONFIG_DIR). The implementation was fixed but the
``Args:`` block still referenced ``~/.basic-memory/``.
- ignore_utils.load_gitignore_patterns: same treatment — the
"combines patterns from" bullet list still called out
``~/.basic-memory/.bmignore``.
- project_service.get_system_status: drop ``# pragma: no cover`` from
the ``try`` and ``json.loads(...)`` lines. The new
``test_get_system_status_reads_watch_status_from_config_dir`` test
writes a valid watch-status.json and asserts on the parsed payload,
so those lines are now exercised. Keeps the pragma on the
``except Exception: pass`` branch, which is still hard to test
without injecting a read failure.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Drew Cain <groksrc@gmail.com>1 parent 99af4ea commit 9d07d24
3 files changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
| 184 | + | |
184 | 185 | | |
185 | 186 | | |
186 | 187 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1139 | 1139 | | |
1140 | 1140 | | |
1141 | 1141 | | |
1142 | | - | |
1143 | | - | |
1144 | | - | |
1145 | | - | |
| 1142 | + | |
| 1143 | + | |
1146 | 1144 | | |
1147 | 1145 | | |
1148 | 1146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
262 | 262 | | |
263 | 263 | | |
264 | 264 | | |
265 | | - | |
| 265 | + | |
| 266 | + | |
266 | 267 | | |
267 | 268 | | |
268 | 269 | | |
| |||
0 commit comments