fix: [BUG] Cursor has errors calling search tool#78
Merged
Conversation
Automated fix generated by Claude Code based on issue analysis. --- 🤖 Generated with Claude Code GitHub Action Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
Updated the naming conventions and handling of `types` and `entity_types` across the codebase for consistency. Modified function definitions, queries, and filters to ensure clear separation and proper usage. Adjusted and added tests to align with the new structure. Signed-off-by: phernandez <paul@basicmachines.co>
272f533 to
4be95bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #75
Changes Summary
Fixed issue #75 where Cursor was having errors calling the search_notes tool. The problem was that the search_notes tool was expecting a complex Pydantic object (SearchQuery) as input, which was confusing Cursor.
Changes:
The fix makes it easier for LLMs like Cursor to make proper calls to the search_notes tool, which will resolve the reported error messages:
Files modified:
Original Issue
Bug Description
Steps To Reproduce
Steps to reproduce the behavior:
try using search tool in Cursor.
Possible Solution
The tool args should probably be plain text and not json to make it easier to call.
🤖 Generated with Claude Code GitHub Action