Skip to content

junos_commit_check: retire sickbay after batfish/batfish#9934 fix#174

Merged
dhalperi merged 1 commit into
mainfrom
spr/main/dd3172d7
May 6, 2026
Merged

junos_commit_check: retire sickbay after batfish/batfish#9934 fix#174
dhalperi merged 1 commit into
mainfrom
spr/main/dd3172d7

Conversation

@dhalperi
Copy link
Copy Markdown
Member

@dhalperi dhalperi commented May 6, 2026

Remove IPv6 prefix normalization sickbay entries now that Batfish
issues fatal red flags for unnormalized IPv6 prefixes.


Prompt:

Fix https://github.com/batfish/batfish/issues/9934 . Note that we just
fixed the similar issue for IPv4. Apply the fix in ./batfish and then
test it by running batfish again (./batfish/tools/bazel_run.sh) and
testing lab-validation junos-commit-checks lab in ./lab-validation

Remove IPv6 prefix normalization sickbay entries now that Batfish
issues fatal red flags for unnormalized IPv6 prefixes.

----

Prompt:
```
Fix batfish/batfish#9934 . Note that we just
fixed the similar issue for IPv4. Apply the fix in ./batfish and then
test it by running batfish again (./batfish/tools/bazel_run.sh) and
testing lab-validation junos-commit-checks lab in ./lab-validation
```

commit-id:dd3172d7
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.50%. Comparing base (f17df9e) to head (20d919e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   83.50%   83.50%           
=======================================
  Files          87       87           
  Lines        4165     4165           
=======================================
  Hits         3478     3478           
  Misses        687      687           
Flag Coverage Δ
unittests 83.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhalperi dhalperi merged commit 61b2718 into main May 6, 2026
110 checks passed
@dhalperi dhalperi deleted the spr/main/dd3172d7 branch May 6, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants