Skip to content

Put progress bar behind the install button#1409

Draft
kolunmi wants to merge 12 commits intomainfrom
progress-bar-in-controls
Draft

Put progress bar behind the install button#1409
kolunmi wants to merge 12 commits intomainfrom
progress-bar-in-controls

Conversation

@kolunmi
Copy link
Copy Markdown
Collaborator

@kolunmi kolunmi commented Apr 13, 2026

Screencast.From.2026-04-12.21-18-42.mp4

@bertob

@AlexanderVanhee
Copy link
Copy Markdown
Collaborator

AlexanderVanhee commented Apr 13, 2026

The button seems to lack a hover and active state, I would put the "Install" and "Cancel" text in a stack so the width of the button doesn't jump when the state changes. The inner bar is way to wide on mobile when in the pending state

@kolunmi
Copy link
Copy Markdown
Collaborator Author

kolunmi commented Apr 13, 2026

@AlexanderVanhee fixed the jumping problem. I've discovered more places wdgt needs improvements along the way 🐹

@kolunmi kolunmi requested a review from AlexanderVanhee April 13, 2026 09:14
@AlexanderVanhee AlexanderVanhee marked this pull request as ready for review April 13, 2026 09:17
@AlexanderVanhee AlexanderVanhee marked this pull request as draft April 13, 2026 09:17
@kolunmi kolunmi marked this pull request as ready for review April 13, 2026 09:18
@kolunmi kolunmi marked this pull request as draft April 13, 2026 09:21
@kolunmi
Copy link
Copy Markdown
Collaborator Author

kolunmi commented Apr 13, 2026

ok worky

@bertob
Copy link
Copy Markdown
Contributor

bertob commented Apr 15, 2026

A few points of feedback from Matrix, so they don't get lost:

  • Decrease the around padding of the inner pill in the initial loading state
  • There's a 2-3s state at the end where the progress bar is full and static, which looks like a different style for the install button. Maybe we should stall a little bit before the end, and only transition to complete when we're ready to move on.
  • When uninstalling an app there's a 2s delay before the buttons are replaced by the Cancel button, it'd be good to have immedate feedback instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants