Skip to content

gopackagesdriver: ignore bazel analysis errors#4567

Open
jayconrod wants to merge 1 commit intomasterfrom
gopackagesdriver-analysis-error
Open

gopackagesdriver: ignore bazel analysis errors#4567
jayconrod wants to merge 1 commit intomasterfrom
gopackagesdriver-analysis-error

Conversation

@jayconrod
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Bazel exits with code 7 (ANALYSIS_FAILURE) when querying a file that's not mentioned in BUILD. gopackagesdriver can returns partial results for code 1 (BUILD_FAILURE), but not 7.

gopackagesdriver often hits this for a new file not added to BUILD. A file= query may still fail in this case because the query will match no labels, but at least that's no longer a bazel error.

Which issues(s) does this PR fix?

Fixes #4565

Other notes for review

Bazel exits with code 7 (ANALYSIS_FAILURE) when querying a file
that's not mentioned in BUILD. gopackagesdriver can returns partial
results for code 1 (BUILD_FAILURE), but not 7.

gopackagesdriver often hits this for a new file not added to BUILD.
A file= query may still fail in this case because the query will
match no labels, but at least that's no longer a bazel error.

For #4565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gopackagesdriver: packages.Load error: unexpected end of JSON input

2 participants