-
-
Notifications
You must be signed in to change notification settings - Fork 692
refactor(toolchains): register runtimes using manifest #3812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rickeylev
wants to merge
25
commits into
bazel-contrib:main
Choose a base branch
from
rickeylev:register-builtin-runtimes-manifest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
85e7778
feat(toolchains): support dynamic registration from remote manifest
rickeylev 7533be3
test(python): bypass bzlmod extension unit tests under legacy workspa…
rickeylev 4cbfe5e
refactor(test): inline python test helpers into python_tests.bzl
rickeylev 2f37ffc
Add add_runtime_manifest_files to python.override
rickeylev 1cad325
Expose freethreaded and archive_flavor in PBS manifest parsing
rickeylev 738d995
Update docs/toolchains.md for add_runtime_manifest_files
rickeylev fd22fc7
Prefer install_only archive flavors in PBS manifest resolution
rickeylev 8eb3ff2
Ignore unrecognized archive flavors in PBS manifest resolution
rickeylev e3e8a78
Merge upstream main into feat.toolchain.manifest
rickeylev 80a6ac4
Register builtin runtimes via centralized runtime manifest
rickeylev 221991c
Refactor runtime manifest parsing to emit simple manifest structs
rickeylev faf57d5
Merge branch 'fetch-runtimes-from-manifest' into register-builtin-run…
rickeylev 634aa42
Fix bzl_library dependencies for Stardoc API generation
rickeylev 437cfb1
Merge remote-tracking branch 'upstream/main' into register-builtin-ru…
rickeylev fd12e42
build: configure secondary mirror fallback for Stardoc and add retry …
rickeylev 8347229
build: strengthen downloader resilience against 504 timeouts
rickeylev f9ae916
build: fix primary pass-through rewrites in downloader_config.cfg
rickeylev d40fa3e
docs: enforce modern Python version on sphinx-build binary
rickeylev 9dc9da6
Robustify manifest platform matching and microarch sorting
rickeylev b6d67d3
Merge remote-tracking branch 'upstream/main' into register-builtin-ru…
rickeylev d056f49
Rename plain flavor attribute to build_flavor in manifest parser
rickeylev 72ac435
feat(toolchains): Populate runtimes_manifest.txt with historical Pyth…
rickeylev 973ef5a
feat(toolchains): Unified historical release manifest, dynamic WORKSP…
rickeylev d9423c2
restore accurate runtimes manifest
rickeylev c0bc526
feat(toolchains): Universal slice refactoring and top-level WORKSPACE…
rickeylev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,9 @@ rewrite ^github\.com/bazelbuild/bazel-skylib/(.*) github.com/bazelbuild/bazel-sk | |
| rewrite ^github\.com/bazelbuild/platforms/(.*) github.com/bazelbuild/platforms/$1 | ||
| rewrite ^github\.com/bazelbuild/rules_kotlin/(.*) github.com/bazelbuild/rules_kotlin/$1 | ||
| rewrite ^github\.com/bazelbuild/rules_shell/(.*) github.com/bazelbuild/rules_shell/$1 | ||
| rewrite ^github\.com/bazelbuild/rules_java/(.*) github.com/bazelbuild/rules_java/$1 | ||
| rewrite ^github\.com/bazelbuild/stardoc/(.*) github.com/bazelbuild/stardoc/$1 | ||
|
|
||
|
|
||
| # Fall back to mirror (secondary) | ||
| # Tracking upstream BCR mirror addition: https://github.com/bazelbuild/platforms/issues/139 | ||
|
|
@@ -14,3 +17,7 @@ rewrite ^github\.com/bazelbuild/bazel-skylib/(.*) mirror.bazel.build/github.com/ | |
| rewrite ^github\.com/bazelbuild/platforms/(.*) mirror.bazel.build/github.com/bazelbuild/platforms/$1 | ||
| rewrite ^github\.com/bazelbuild/rules_kotlin/(.*) mirror.bazel.build/github.com/bazelbuild/rules_kotlin/$1 | ||
| rewrite ^github\.com/bazelbuild/rules_shell/(.*) mirror.bazel.build/github.com/bazelbuild/rules_shell/$1 | ||
| rewrite ^github\.com/bazelbuild/rules_java/(.*) mirror.bazel.build/github.com/bazelbuild/rules_java/$1 | ||
| rewrite ^github\.com/bazelbuild/stardoc/(.*) mirror.bazel.build/github.com/bazelbuild/stardoc/$1 | ||
|
|
||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All 3 downloader_config files are identical - can/should they be deduped? In a separate PR. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra newlines, here and in other downloader_config files.