Skip to content

bazelci: sanitize fork-PR filenames in create_config_validation_steps #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyakei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bazelci: sanitize fork-PR filenames in create_config_validation_steps #2591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions buildkite/bazelci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import random
import re
import requests
import shlex
import shutil
import stat
import subprocess
Expand Down Expand Up @@ -3393,19 +3394,22 @@ def get_platform_for_task(task, task_config):
return task_config.get("platform", task)


_SAFE_CONFIG_PATH = re.compile(r"^\.bazelci/[A-Za-z0-9_./-]+\.(yml|yaml)$")


def create_config_validation_steps(git_commit):
config_files = [
path
for path in get_modified_files(git_commit)
if path.startswith(".bazelci/") and os.path.splitext(path)[1] in CONFIG_FILE_EXTENSIONS
if _SAFE_CONFIG_PATH.fullmatch(path)
]
return [
create_step(
label=":cop: Validate {}".format(f),
commands=[
fetch_ci_scripts_command(),
"{} bazelci.py project_pipeline --file_config={}".format(
PLATFORMS[DEFAULT_PLATFORM]["python"], f
PLATFORMS[DEFAULT_PLATFORM]["python"], shlex.quote(f)
),
],
platform=DEFAULT_PLATFORM,
Expand Down