Skip to content

ci(terraform): restrict the privileged terraform job to non-fork PRs #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adilburaksen wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

ci(terraform): restrict the privileged terraform job to non-fork PRs #2682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/terraform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,14 @@ jobs:
# Job 2: Terraform Execution
terraform:
needs: detect-changes
# Run only if we have changed orgs AND (it's a push to master OR PR from trusted users)
if: needs.detect-changes.outputs.orgs != '[]'
# Run only if we have changed orgs AND (it's a push to master OR a PR from this
# repository, not a fork). Fork pull requests must not reach this job: it loads
# GCP credentials and runs `terraform plan` over the PR's .tf files, which executes
# attacker-controlled HCL (module sources, `external` data sources).
if: >-
needs.detect-changes.outputs.orgs != '[]'
&& (github.event_name == 'push'
|| github.event.pull_request.head.repo.full_name == github.repository)
runs-on: ubuntu-latest

# Lock per organization. Cancels old runs on PRs (saves time), but queues pushes (safe apply).
Expand Down