[codex] Starlarkify declare_other_output_file#760
Closed
dzbarsky wants to merge 2 commits into
Closed
Conversation
Declare compile outputs as shareable artifacts under the package _objs directory using the rule context. Remove the redundant configuration arguments from _get_compile_output_file and its callers.
Declare per-object debug and ThinLTO indexing outputs beside the object file with actions.declare_file. This preserves the object file parent directory without calling the native helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace both
_cc_internal.declare_other_output_filecalls withactions.declare_file(..., sibling = object_file). The.dwoand ThinLTO indexing outputs keep the object file's parent directory while using the standard Starlark action API.This PR is stacked on #758. Its diff against
mainincludes #758 until #758 merges.Validation
buildifier -mode=check -lint=warn cc/private/compile/compile.bzlbazel test --jobs=2 //tests/cc/common:cc_common_tests //tests/cc/common:cc_binary_configured_target_tests //tests/cc/common:cc_library_configured_target_tests //tests/cc/common:debug_info_packaging_tests(78 tests passed)