Starlarkify dynamic_library_soname#762
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
Compute the dynamic library SONAME from the output artifact root and root-relative path. Reuse the path escaping used by cc_common.escape_label and cover preserved and transitioned output names.
dzbarsky
changed the title
Collaborator
|
discussion in #763 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
_cc_internal.dynamic_library_sonamewith a Starlark implementation.dynamic_library_sonamepreserves the output basename when requested; otherwise it applies the configuration mnemonic'sST-suffix and the same path escaping used bycc_common.escape_labelto the output's root-relative path.The configuration mnemonic is read from the output artifact root, which preserves link outputs created for transitioned configurations without adding another configuration argument to the link functions.