Fix C++20 modules compilation failing during analysis

[fmeum]

Building any target with the cpp_modules feature failed at analysis time with:

parameter 'needs_include_validation' got value of type 'NoneType', want 'bool'

_create_scan_deps_action called _create_compile_action without passing needs_include_validation, so it defaulted to None and was rejected by create_cc_compile_action. Pass it through.

The module-compile path then failed analysis as well, because _create_compile_action did not accept the C++20 module output/modmap arguments (additional_outputs, module_files, modmap_file, modmap_input_file) that its caller already passes:

_create_compile_action() got unexpected keyword arguments: ...

Accept and forward them.

Fixes #773

[fmeum]

@PikachuHyA Could you give this a try?

[PikachuHyA]

@PikachuHyA Could you give this a try?

@fmeum it works . thanks.

[PikachuHyA]

@fmeum

Can we add a CI job with Ubuntu 24.04 (Ubuntu 26.04 would be better) and Bazel 9 to watch over the C++20 Modules-related features, so that they don’t break by accident during refactoring?

Also, I’m continuing to improve Bazel’s support for C++20 Modules, such as

• Support Using Clang Module Map to Avoid mixing #include and import pr… #777
• Support C++20 modules, GCC part #774
• WIP: support std module #522

. If we have a related CI job to keep an eye on it, it would make things easier for reviewers.

[lilygorsheneva]

Fixed by 840d532 and 1a20833

Sorry for not seeing this earlier; I was out of office and didn't notice an issue until the bazel team complained.
https://github.com/bazelbuild/bazel/blob/master/src/test/shell/bazel/cc_integration_test.sh has tests that should have caught this, working on getting them into rules_cc

[fmeum]

@lilygorsheneva What about this snippet? Isn't something like this needed as well?

https://github.com/bazelbuild/rules_cc/pull/775/changes#diff-6eee86daef76d9a203a3d239504c0c2644cc65a4a95acd57f29336b74073c07f

[lilygorsheneva]

If you mean _starlark_cc_semantics.needs_include_validation(language), I don't know; currently preserving the existing behavior (matching default set in Java)

[fmeum]

Ah, no, I'm referring to these extra parameters:

version_dependent_kwargs["module_files"] = module_files
        version_dependent_kwargs["modmap_file"] = modmap_file
        version_dependent_kwargs["modmap_input_file"] = modmap_input_file

that weren't passed on correctly. Perhaps that part of my PR is still needed?

[lilygorsheneva]

Oh; bad copy-paste in my previous comment, I should have said " 0662ed2 and 1a20833 ", not " 840d532 and 1a20833 "