util/process_wrapper: improve resilience to non-JSON output#4021
Open
th0br0 wants to merge 1 commit into
Open
Conversation
th0br0
force-pushed
the
process_wrapper_non_json
branch
from
f0d457b to
2ef5a58
Compare
slackito
reviewed
May 18, 2026
Collaborator
slackito
left a comment
slackito
left a comment
There was a problem hiding this comment.
I think the general idea looks good. If I understand correctly, instead of looking for a particular pattern of output messages that should be converted to JSON warnings, now we look for strings that are likely JSON (if they start with a '{') and convert anything else to JSON warnings, right?
Pre-merge checks are failing, specifically //test/process_wrapper:rustc_quit_on_rmeta. Can you take a look?
| format: ErrorFormat, | ||
| metadata_emitted: &mut bool, | ||
| ) -> Result<LineOutput, String> { | ||
| // LLVM can emit lines that look like the following, and these will be interspersed |
Collaborator
There was a problem hiding this comment.
We're still trying to convert non-JSON lines to JSON so I think this comment explaining why we need to do that should be preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make process_line in process_wrapper catch parsing failures and wrap non-JSON lines in valid JSON warnings.
This prevents crashes when rustc emits unexpected warnings.