Skip to content

crate_universe: emit build_script_env_files on rendered cargo_build_script targets #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashi009 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

crate_universe: emit build_script_env_files on rendered cargo_build_script targets #4044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crate_universe/src/rendering.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,12 @@ impl Renderer {
.unwrap_or_default(),
platforms,
),
build_script_env_files: SelectSet::new(
attrs
.map(|attrs| attrs.build_script_env_files.clone())
.unwrap_or_default(),
platforms,
),
rustc_flags: SelectList::new(
// In most cases, warnings in 3rd party crates are not
// interesting as they're out of the control of consumers. The
Expand Down
2 changes: 2 additions & 0 deletions crate_universe/src/utils/starlark.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ pub(crate) struct CargoBuildScript {
pub(crate) aliases: SelectDict<Label, String>,
#[serde(skip_serializing_if = "SelectDict::is_empty")]
pub(crate) build_script_env: SelectDict<String, String>,
#[serde(skip_serializing_if = "SelectSet::is_empty")]
pub(crate) build_script_env_files: SelectSet<String>,
#[serde(skip_serializing_if = "Data::is_empty")]
pub(crate) compile_data: Data,
#[serde(skip_serializing_if = "SelectDict::is_empty")]
Expand Down