Skip to content

feat: add receive schemas to check-docks worflow#853

Open
Gara-Dorta wants to merge 1 commit into
bbernhard:masterfrom
Gara-Dorta:release-fix
Open

feat: add receive schemas to check-docks worflow#853
Gara-Dorta wants to merge 1 commit into
bbernhard:masterfrom
Gara-Dorta:release-fix

Conversation

@Gara-Dorta
Copy link
Copy Markdown
Contributor

@Gara-Dorta Gara-Dorta commented May 23, 2026

This PR adds the receive schemas to the check-docs.yml workflow. Here is a successful run of it https://github.com/Gara-Dorta/signal-cli-rest-api/actions/runs/26340800873

This is a follow up of #849 and #842, they got merged at the same time but they have this interaction with each other.

- name: Download and inject receive schemas
working-directory: src/docs
run: |
SIGNAL_CLI_VERSION="$(grep -m1 '^ARG SIGNAL_CLI_VERSION=' ../../Dockerfile | cut -d= -f2)"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too happy with getting the signal version like this. I think a better approach is to have a separate file in the repo and read it from there. Like how signal-cli has the lib version in this file https://github.com/AsamK/signal-cli/blob/master/libsignal-version

However to keep with single responsibility PRs. If that is something you'd like, I'd do it in a separate one.

@bbernhard
Copy link
Copy Markdown
Owner

Thanks - looks good to me! But I think it might make sense to keep this PR open until your signal-cli CI PR is merged. :)

@Gara-Dorta
Copy link
Copy Markdown
Contributor Author

I think so too. However, getting code merged in signal-cli is a slow process. So if you need to make a release in the meantime, I've made new releases in my fork https://github.com/Gara-Dorta/signal-cli/releases so that this workflow and the one #842 don't crash and download the correct json files for each signal-cli version.

@bbernhard
Copy link
Copy Markdown
Owner

bbernhard commented May 30, 2026

Hmm...what if we check out signal-cli and build the json schemas with ./gradlew jsonSchemas directly in this CI job? 🤔

@Gara-Dorta
Copy link
Copy Markdown
Contributor Author

Gara-Dorta commented May 31, 2026

If we are building it ourselves, I think it makes more sense to add it as a new artifact output in https://github.com/bbernhard/signal-cli-native-builds/blob/master/.github/workflows/build.yml than do it here.

When working on #842 I gave a quick try. However, after a few minutes of coding it felt silly to duplicate the work in there when I could simply publish a release in my signal-cli fork by uploading a tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants