Fixing potential bugs / vulnerabilities#855
Open
Zetles96 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran GoSec static analysis on the project due to some compliance checks with using the api, and instead of testing if it was axtually vulnerable code, i decided to just fix the potential bugs instead.
GoSec found stuff such as
CWE-367 (G122): Time-of-Check to Time-of-Use (TOCTOU) Race Condition
CWE-78 (G204): Subprocess Launched with a Variable
CWE-276 (G301, G306): Permissive File/Directory Permissions
And a bumch of.
CWE-703 (G104): Unhandled Errors
I can make another pr with GoSec as a part of the pipeline if you want that.