feat(strr-api): new api for examiner notes feature to post and retrieve notes#1691
Open
jimmypalelil wants to merge 4 commits into
Open
feat(strr-api): new api for examiner notes feature to post and retrieve notes#1691jimmypalelil wants to merge 4 commits into
jimmypalelil wants to merge 4 commits into
Conversation
jimmypalelil
force-pushed
the
1687-examiner-notes-api
branch
4 times, most recently
from
3b84dc6 to
0eb8578
Compare
jimmypalelil
requested review from
Jacky-Pham,
JazzarKarim,
dimak1 and
thorwolpert
as code owners
jimmypalelil
commented
Jun 2, 2026
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| NOTE_LIST_MAX = 500 |
Collaborator
Author
There was a problem hiding this comment.
confirmed with @pasherwo about not wanting pagination on this api and restrict the list count to just the latest 500
jimmypalelil
commented
Jun 2, 2026
| @swag_from({"security": [{"Bearer": []}]}) | ||
| @cross_origin(origin="*") | ||
| @jwt.requires_auth | ||
| @jwt.has_one_of_roles([Role.STRR_EXAMINER.value, Role.STRR_INVESTIGATOR.value]) |
Collaborator
Author
There was a problem hiding this comment.
confirmed with @pasherwo that both examiners and investigators could create and view notes
dimak1
reviewed
Jun 2, 2026
JazzarKarim
reviewed
Jun 2, 2026
JazzarKarim
reviewed
Jun 2, 2026
JazzarKarim
approved these changes
Jun 2, 2026
Collaborator
JazzarKarim
left a comment
JazzarKarim
left a comment
There was a problem hiding this comment.
Aside from that one comment, I think it looks good! Great stuff Jimmy.
Please if possible, wait for Dima's approval as well before merging. Thanks!
dimak1
reviewed
Jun 2, 2026
jimmypalelil
force-pushed
the
1687-examiner-notes-api
branch
from
3c7fd54 to
7948027
Compare
dimak1
approved these changes
Jun 4, 2026
dimak1
approved these changes
Jun 4, 2026
JazzarKarim
approved these changes
Jun 4, 2026
jimmypalelil
force-pushed
the
1687-examiner-notes-api
branch
from
7948027 to
3775cc2
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Implements a new examiner notes API feature that allows STRR staff (examiners and investigators) to create and retrieve internal notes on applications and registrations for audit trail and collaboration purposes.
New Endpoints
GET /applications/{application_number}/notes- List notes for an applicationPOST /applications/{application_number}/notes- Create note on applicationGET /registrations/{registration_id}/notes- List notes for a registrationPOST /registrations/{registration_id}/notes- Create note on registrationAll endpoints require either
STRR_EXAMINERorSTRR_INVESTIGATORrole.Business Rules
Database Changes
20260529_1200_c9e8f7a6b5d4_examiner_notes.pyexaminer_noteswith: