Feature pg8000 graceful shutdown#4457
Open
panish16 wants to merge 17 commits into
Open
Conversation
Calls setup_pg8000_close_event_listener(engine) after db init in all lear queue services and legal-api. Scoped to long-lived Cloud Run services only — GCP jobs excluded as no pg8000 errors observed in logs. Resolves #33564
…utdown for legal-api
… blocks Remove the DBConfig blocks from all 5 queue services (business-bn, business-emailer, business-pay, business-filer, business-digital-credentials). These services connect via SQLALCHEMY_DATABASE_URI in their configs and don't need Cloud SQL Connector connection pooling. The setup_pg8000_close_event_listener call is now unconditional since the function already returns early for non-pg8000 engines.
…listener DBConfig/SQLALCHEMY_ENGINE_OPTIONS setup was removed from __init__.py without being moved anywhere, breaking Cloud SQL connections on GCP. Move it into each service's config.py alongside the existing CLOUDSQL_INSTANCE_CONNECTION_NAME block. Replace legal-api's local _setup_pg8000_graceful_shutdown reimplementation with setup_pg8000_close_event_listener from cloud_sql_connector.
…s updated setup_pg8000_close_event_listener is not yet available on the cloud-sql-connector-python3.9 branch used by legal-api, so retain the local _setup_pg8000_graceful_shutdown implementation. DBConfig setup remains moved to config.py.
…dentials so coverage.xml is generated and uploaded
Python 3.9 branch of sbc-connect-common does not have setup_pg8000_close_event_listener. Restore the local _setup_pg8000_graceful_shutdown function and point the lock back to the valid bcgov commit (e82cd710) so the Docker build can clone the dependency.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity###
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).