Skip to content

33671 fix completing party sync issue #4458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vysakh-menon-aot merged 1 commit into from
Jun 4, 2026
+7 −4
Merged

33671 fix completing party sync issue #4458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions colin-api/src/colin_api/models/filing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1482,11 +1482,14 @@ def add_filing(cls, con, filing: Filing) -> int:
office_text = cls._process_office(cursor=cursor, filing=filing)

if parties := filing.body.get('parties', []):
has_completing_party = False
for party in parties:
has_completing_party = cls._create_party_roles(cursor=cursor,
party=party,
business=business,
event_id=filing.event_id)
completing_party_created = cls._create_party_roles(cursor=cursor,
party=party,
business=business,
event_id=filing.event_id)
if completing_party_created:
has_completing_party = True
if (filing.filing_type == 'incorporationApplication' and
filing.business.corp_type != Business.TypeCodes.COOP.value and
not has_completing_party):
Expand Down
Loading