Skip to content

Fix/conflict check namex solr api#872

Closed
Oluwapizzy wants to merge 30 commits into
bcgov:feature-solr-mergedfrom
Oluwapizzy:fix/conflict-check-namex-solr-api
Closed

Fix/conflict check namex solr api#872
Oluwapizzy wants to merge 30 commits into
bcgov:feature-solr-mergedfrom
Oluwapizzy:fix/conflict-check-namex-solr-api

Conversation

@Oluwapizzy
Copy link
Copy Markdown
Collaborator

Calls /possible-conflict-names on namex-solr-api
replaces broken endpoints on legacy namex

severinbeauvais and others added 28 commits August 26, 2025 14:36
* - deleted obsolete key VUE_APP_BUSINESSES_URL
- app = 5.5.46
- fixed Business Registry URL in Affiliation Error Modal
- fixed Staff Dashboard breadcrumb

* - updated browserslist

---------

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
* - app version = 5.6.0
- imported latest LD JS client SDK v3.9.0
- updated UpdateUserMixin to create contexts
- updated featureFlags module to use contexts

* - renamed updateUser -> updateLaunchDarkly
- used getter instead of computing KC roles again
- combined updateUser + updateLaunchDarkly
- renamed featureFlags.ts -> launchDarkly.ts
- misc cleanup

---------

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
Co-authored-by: bobby <bobbyjin935@gmail.com>
* - misc cleanup
- updated babel config file
- moved index.html from /public to /
- updated index.html
- deleted obsolete jest config file
- app version = 5.7.0
- updated scripts in package file
- deleted obsolete dependencies
- added necessary dependencies
- recreated pnpm lock file
- updated patch to use import.meta
- deleted obsolete postcss config file
- added robots file
- replaced process.env -> import.meta.env
- replaced JEST_WORKER_ID -> VITEST
- added woff2 fonts
- updated font sources in CSS
- replaced getBaseUrl with direct sessionstorage.getItem()
- fixed some image sources
- deleted obsolete payment-utils.ts
- changed getConfig to non-async
- added vuetify css import
- changed v-img to img
- deleted unused isJestRunning computed
- replaced appBaseURL -> namexApiUrl
- added check for valid user/org before callling UpdateLdUser
- added BASE_URL to session storage
- added NAMEX_API_URL to session storage
- updated Vuetify import
- deleted appBaseURL export
- deleted commented-out console.log
- commented out unneeded console.log (for now)
- updated unit tests
- updated types in tsconfig file
- added vite config file
- updated vue config file

* - fixed v-icon size and color

---------

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
Update pnpm installation and development commands
* - app version = 5.8.0
- installed Pinia dependencies
- updated Getter and Action decorators
- misc cleanup
- created Filing Types enum
- created Error interface
- created Payment models
- removed unneeded await for store actions
- converted Vuex Modules to separate stores
- created getStores plugin
- cleaned up error store
- cleaned up payment store
- delete env config
- deleted obsolete properties from main store state
- deleted unneeded stateModel property
- refactored actions and mutations into "sub store"
- refactored getters into "sub store"
- refactored state into "sub store"
- created new Pinia main store from sub stores
- now call mutations as functions instead of "commit"
- misc cleanup / type fixes
- moved getXXX in main.ts
- attached Vuex store to Vue instance
- mocked Vuex store for unit tests
- updated misc comments
- final commit with store as 3 sub-stores

* - changed actions back to exported functions
- changed getters back to exported functions
- changed state back to exported const
- updated store definition
- misc fixes and cleanup
- updated Reg Search API URL in example env

* - changed getNrState to return NrState
- cleaned up some typings
- changed getNrId to return number

* - attached Vuetify to Vue
- use current Vuetify instance to get breakpoint

* - small vault comment fixes
- approve building "vue-demi" to solve "missing export" issue

* - fixed "cannot read null key properties"

* - updated lockfile

- updated pnpm lock file

- lock file with pnpm v9

* - added exclude in Vite config

---------

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
…bcgov#851)

* define disabled wait time and change priority wait time to Days

* update

* lint error

* Update

* linting

* update
…o Number (bcgov#853)

* bugfix: Add folio number to RENEW payment when the first payment already had it

- bump version to 5.8.3

* chore: Update folio number assignment logic to use PaymentAction.CREATE filter

* cleanup
* Update `MRAS_MAX_LENGTH` constant to 60 in new-request constants

* version bump

* chore: bump version to 5.8.3
* update priority tooltips

* Remove unnecessary newline in stats.vue
* fix: name input rules logic and add xpro validation

- add validation/disable button in sub search modal

* fix: correct defaultRules return order in name input component

* fix: update search button logic and add xpro name validation

- Update `isSearchBtnDisabled` logic for button disablement
- Add `isValidXproName` getter for XPRO name length validation

* chore: bump version to 5.8.6 and remove unused import in search component

* fix: adjust max length validation for XPRO name flow

- Use dynamic max length based on `isXproFlow` condition.
* Update `MRAS_MAX_LENGTH` constant to 60 in new-request constants

* version bump

* chore: bump version to 5.8.3

* fix: remove "Release Notes" link from footer and update sbc-common-components patch

* build lock with pnpm 9
* - app version = 5.8.9
- updated banner styling

* - changed span to div

---------

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
…ver going to DRAFT after X amount of days

Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
…ver going to DRAFT after X amount of days

Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
31897 - FIX: WAIT TIME, Estimated Review Time, PENDING_PAYMENT NRS ne…
…ver going to DRAFT after X amount of days

Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
31897 - FIX: WAIT TIME, Estimated Review Time, PENDING_PAYMENT NRS ne…
Comment thread app/src/store/actions.ts
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the commented codes instead?

Copy link
Copy Markdown
Collaborator

@stevenc987 stevenc987 May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the latest version is 5.9.1 on main branch in package.json. Please confirm that is the latest version you got.

@Oluwapizzy Oluwapizzy closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants