Skip to content

PPR replace GCP SA keys with container ADC for GCP API calls#2329

Merged
doug-lovett merged 2 commits into
bcgov:mainfrom
doug-lovett:33582-ppr-remove-sa-keys
Jun 1, 2026
Merged

PPR replace GCP SA keys with container ADC for GCP API calls#2329
doug-lovett merged 2 commits into
bcgov:mainfrom
doug-lovett:33582-ppr-remove-sa-keys

Conversation

@doug-lovett
Copy link
Copy Markdown
Collaborator

Issue #: /bcgov/entity#33582

Description of changes:
SRE has a policy of rotating service account keys every 3 months. Removing the keys from the container configuration removes the need to update the containers and redeploy when the keys change.

  • Verify or enable IAM Service Account Credentials API on the project.
  • Assign the container service accounts the correct roles: storage admin, pub/sub publisher, and service account token creator.
  • Update all PPR jobs that use a GCP SA key: securd party notification.
  • Update the PPR API service
  • Remove environment variable from container configuration.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Signed-off-by: Doug Lovett <doug@diamante.ca>
@doug-lovett doug-lovett self-assigned this May 29, 2026
Signed-off-by: Doug Lovett <doug@diamante.ca>
@doug-lovett doug-lovett requested a review from eve-git May 29, 2026 23:38
@eve-git
Copy link
Copy Markdown
Collaborator

eve-git commented Jun 1, 2026

@doug-lovett I approved the code changes, but I noticed the code-coverage check is failing. Does this need to be addressed in this PR?

@doug-lovett
Copy link
Copy Markdown
Collaborator Author

@eve-git thanks, the CI script code coverage issue has been around for a while, I think it can be left as a separate cleanup task in a different PR.

@doug-lovett doug-lovett merged commit aec3b88 into bcgov:main Jun 1, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants