CCP-3514 husky and commitlint#9
Closed
jasonchung1871 wants to merge 12 commits into
Closed
Conversation
jasonchung1871
requested review from
BrandonSharratt,
NavdeepKaur1811 and
usingtechnology
jasonchung1871
force-pushed
the
feat/CCP-3514-improve-pipeline
branch
from
c0b8e79 to
39eadb1
Compare
jasonchung1871
changed the title
jasonchung1871
changed the title
Devcontainer now should work on Windows, was trying to use the command prompt instead of bash. The build images should also now use the root context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements husky to enforce precommit and commit-msg commands. The precommit command will run pnpm lint from the workspace root and will not allow a commit to be made unless linting succeeds. The commit-msg command will check the commit message and ensure it follows the conventional commit standard and will prevent the commit from being created unless it succeeds.