Add rspec definitions for riscv payloads#9
Merged
bcoles merged 1 commit intoApr 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm getting a little crazy with the rspec inconsistencies. I'm seeing different results running things on Github and locally, and non-deterministic behavior all-around.
It does not help that the fix here is not considered a test failure (and is not listed as a failure), but is an
errorthat will cause the tests to fail 😞Locally, this change makes the branch pass (and also not error). I simply fail to understand why Github testing is complaining about payload cache size for windows payloads:
Anyway, this PR fixes the
errorin rspec so even though everything passes, the tests will pass:Thanks for listening to me rant, and thank you for being patient.