CLI local manifest performance improvements#4622
Merged
Merged
Conversation
Contributor
|
Lightbeam link |
This reverts commit 6c4c4ea.
Contributor
|
Lightbeam link |
Contributor
|
Lightbeam link |
commit 582e809 Author: Chris Hanna <chris@beamable.com> Date: Wed May 27 15:06:50 2026 -0400 rc2 commit d900fc8 Author: VitorBeamable <vitor@beamable.com> Date: Wed May 27 13:20:55 2026 -0300 Fix and Improvements to Admin Console (#4619) * Add UIScaler in the ConsoleConfiguration and add Toggle behaviour to the Admin Console * Remove close button * Rework the Input system in the BeamableAdminConsole to improve the stability * Add InputSystem dll to Unity.Beamable asmdef * Fix cursor when using tab to autocomplete * Beam "Samples" Toolbar Menu Item * Check if TMPro Resources are in the project. Import TMP Resource Package if does not. * Redo missing fix that foce hide when using legacy Input system since the texfield intercept all calls and consume them before the Update commit fc92b80 Author: felipe-beamable <felipe@beamable.com> Date: Wed May 27 13:18:16 2026 -0300 Fix - Flatten start-session event for athena acceptance (#4621) * Fix - Flatten start-session event for athena acceptance commit f83367b Author: gabrielbeamable <141041673+gabrielbeamable@users.noreply.github.com> Date: Wed May 27 12:29:13 2026 -0300 [CLI] Portal Extensions microservice client support (#4610) * remove need to have an initialized player to show a portal extension * fix dev web script for newer pnpm version * Fix error when trying to add dep to PE and generating client * websdk fix, content manifest 404 should be considered just empty manifest * fix portal extension client gen * generate typescript client for pe and fix client generation * update react template * fix template updater * debug install log * attempt install * gate source * cli issues * namespace * test * lower case --------- Co-authored-by: Chris Hanna <chris@beamable.com> commit 545788d Author: DiasAtBeamable <gmoraes@beamable.com> Date: Tue May 26 14:34:25 2026 -0300 feature: Added support for detecting remote portal extensions in project ps. (#4618)
Contributor
|
Web SDK Sample Build link |
Contributor
|
Lightbeam link |
Contributor
|
Web SDK Sample Build link |
Contributor
|
Lightbeam link |
…ible until it is required with it working in the background
Contributor
|
Web SDK Sample Build link |
Contributor
|
Lightbeam link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating local manifest is something that is done on beginning of many commands and it currently can take substantial amount of time, now it can be even worse due to scanning for the portal extensions. With the help of the Claude I've refactored that code so in my case it started taking ~20 ms to build local manifest compared to the previous ~420, which is ~21x improvement.
Before:
After:
One other thing I've done is refactored how the
CalculateDirectorySizeis done- it preserves the same functionality, but it was around twice as fast- 2.528 ms vs 1.279 ms in the test benchmark project I've created.I've also included a setup of locale to resolve issue that I had during test with error during parsing of
10.0value byinternalArg?.GetDefaultValue()?.ToString()code.