Content manifest caching #4435#4643
Open
Leinnan wants to merge 1 commit into
Open
Conversation
Contributor
|
Lightbeam link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4435 .
In my test when I was using the content manifest with less than 100 entries the time to get the content manifest were similar. When I've increased the manifest size to have bigger size (~1600 entries) the difference start to grow, but it was not consistent. I would say that the biggest win would be for cases where there is a big content manifest that changes from time to time so the clients would need to download a lot of data less frequently. There could be cases where there is a small manifest that does change often, then it could be worse than current solution. Instead of current one request(get me the latest manifest) it will perform two (get me the latest manifest UID, then the manifest with that UID) which is why I've introduced option to opt out of it with define symbol
BEAMABLE_OPTOUT_MANIFEST_FILE_CACHING.