Validating Logistics Specification against the Beckn Core specification v 1.1.0, validating examples against the updated Logistics specification#11
Open
rajaneeshk90 wants to merge 26 commits into
Conversation
emmayank
reviewed
Jan 22, 2024
|
|
||
| Below is an example of a `get_rating_categories` request | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Add Example for get_rating_cateogires
emmayank
reviewed
Jan 22, 2024
|
|
||
| Below is an example of an `rating_categories` callback | ||
| ``` | ||
|
|
emmayank
suggested changes
Jan 22, 2024
emmayank
left a comment
emmayank
left a comment
There was a problem hiding this comment.
Hi @rajaneeshk90 ,
The Changes are fine. just 2 comments are added. please resolve and update the PR.
Thanks
Author
|
Hi @emmayank , Thank you for taking the time to review the pull request. In response to your feedback, I have incorporated the suggested changes. Please take another look at the updated version. Thanks |
emmayank
approved these changes
Jan 23, 2024
|
Thanks @rajaneeshk90 for making the change. I have approved your pull request. requesting @ravi-prakash-v to approve the pull request and merge it with the |
…ation, service fulfillment and post fulfillment stages
6 tasks
rajaneeshk90
changed the title
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the Logistics.yaml file with the core-spec v1.1.0 version. Also, validate the examples JSON files given in the example directory and in the implementation guide against core-spec v1.1.0.
Related ticket: beckn/beckn-ui-workspace#486