Repository navigation
connector: ignore messages that convert to nothing instead of panicking - #287
Merged
Merged
Conversation
|
No issues found.
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
highesttt
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several conversion paths return
nil, nilto skip a message: whitespace-only text, an image with no OID or download URL, and some post notifications. Backfill already treats a nil result as "skip". Live events, though, pass it straight to bridgev2, which dereferences it inPortal.getRelationMeta:The panic gets recovered, so the message is skipped anyway, but each one logs a panic and a stack trace. The live-event
ConvertMessageFuncnow turns a nil result intobridgev2.ErrIgnoringRemoteEvent, which is how bridgev2 expects a converter to say "skip this". Handling it at that one boundary covers every current and futurenil, nilpath without touching each handler.Before / after: not run, because the messages that trigger this can't be produced on demand.
Tag
@indentto continue the conversation here.