-
Notifications
You must be signed in to change notification settings - Fork 4
Add message retention related data types #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beeper
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -186,6 +186,17 @@ type ClientUserBootSubteams struct { | |
| type TeamPrefs struct { | ||
| MsgEditWindowMins *int `json:"msg_edit_window_mins,omitempty"` | ||
| AllowMessageDeletion *bool `json:"allow_message_deletion,omitempty"` | ||
|
|
||
| // Message retention defaults. The *_type fields use 1 = retain all messages, | ||
| // 2 = delete after the matching *_duration (in days); other values mean no | ||
| // automatic deletion. Public channels use RetentionType/RetentionDuration, | ||
| // private channels use the Group* fields and DMs/MPIMs use the DM* fields. | ||
| RetentionType int `json:"retention_type,omitempty"` | ||
| RetentionDuration int `json:"retention_duration,omitempty"` | ||
| GroupRetentionType int `json:"group_retention_type,omitempty"` | ||
| GroupRetentionDuration int `json:"group_retention_duration,omitempty"` | ||
| DMRetentionType int `json:"dm_retention_type,omitempty"` | ||
| DMRetentionDuration int `json:"dm_retention_duration,omitempty"` | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Type inconsistency with surrounding TeamPrefs fields: the existing prefs in this struct use pointer types ( |
||
| } | ||
|
|
||
| type BootTeam struct { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc inconsistency with
ConversationRetention.Type: the comment over inconversation.goenumerates 0/1/2/3 with concrete meanings (0=inherit workspace default, 3=custom timeline), but here "other values" is left vague. Since both fields are decoding the same Slack retention enum it would be clearer to use the same enumeration here so callers know about the3and0cases.