style: ruff-format tests/test_cli_hub_env.py (CI gate fix)#751
Merged
Conversation
#750's test rewrite passed `ruff check` (lint) but I didn't run `ruff format --check` — the CI `test` job runs format-check as a gating step and failed on `Would reformat: tests/test_cli_hub_env.py`. This applies ruff format (collapses the set comprehension to ruff's canonical form). No logic change. Verified: ruff format --check + ruff check + ty + the test file all pass.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_3521e66f-ae2d-4937-88cd-38e1e33f93c8) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #750: that test rewrite passed
ruff checkbut I hadn't runruff format --check, which the CItestjob runs as a gating step — it failed onWould reformat: tests/test_cli_hub_env.py. This appliesruff format(collapses the set comprehension to canonical form), no logic change. With this, #665's gate should go fully green (the ANSI test fix from #750 + this format fix were the only two failures). Verified locally: ruff format --check + ruff check + ty + the test all pass.Note
Low Risk
Test-only whitespace/formatting; no production or assertion changes.
Overview
CI-only formatting fix for
tests/test_cli_hub_env.py:ruff formatcollapses thevisibleset comprehension intest_environment_group_is_hidden_but_still_resolvesto a single line. No test logic or assertions change—this unblocks theruff format --checkgate that failed after the prior test rewrite (#750).Reviewed by Cursor Bugbot for commit 6842565. Bugbot is set up for automated code reviews on this repo. Configure here.