Skip to content

ENH adding new tasks (MRI, demoisaicing)#5

Open
tomMoral wants to merge 34 commits into
mainfrom
new-tasks
Open

ENH adding new tasks (MRI, demoisaicing)#5
tomMoral wants to merge 34 commits into
mainfrom
new-tasks

Conversation

@tomMoral
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member Author

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick comments.

Comment thread solvers/ifft2.py Outdated
Comment thread objective.py Outdated
x = x.reshape(1, self.in_channels, x.shape[3], x.shape[4])

# Reshape for MRI specific processing
x = x.reshape(1, self.in_channels, x.shape[3], x.shape[4])
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it forcing the batch_size to be 1? why not x.shape[0]? Why do you need to reshape at all actually?

Comment thread benchmark_utils/fastmri_dataset.py Outdated
Comment thread solvers/diffpir.py
Comment thread solvers/dpir.py
Comment thread .gitignore
@etyl etyl mentioned this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants