fix: preserve clipboard contents and exit cleanly#18
Merged
benmaster82 merged 2 commits intoJul 19, 2026
Merged
Conversation
benmaster82
added a commit
that referenced
this pull request
Jul 19, 2026
- injector: when the full multi-format clipboard snapshot fails (e.g.
an app with delayed rendering holds a format), fall back to the
historical text-only save/restore instead of aborting the paste.
The text-only restore also skips if the clipboard changed during
the paste. Adds fallback tests.
- README: restore a strong privacy tagline ("No cloud required, no
account, no telemetry") and warn that pointing the OpenAI-compatible
URL at a remote endpoint forfeits the offline/privacy guarantees.
Verified: 68 tests green, plus a real Win32 smoke test (bitmap on the
clipboard survives swap-to-text and restore with correct pixels).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
benmaster82
added a commit
that referenced
this pull request
Jul 19, 2026
PR #18 was based on a main where _finish_startup still persisted a model_ready_* DB flag; the merge reintroduced db.save_setting( model_flag, ...) after d5efdac had replaced the flag with real HF cache detection, crashing the startup thread with a NameError. The app then kept running with a tray icon but no hotkeys. Removes the stale line and adds the missing happy-path startup regression test (only the quit-during-load path was covered). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
WritHer previously backed up only Unicode text, so pasting dictated text could destroy screenshots, copied files, and other non-text clipboard formats. Its tray callback could also log
Shutdown completewhile the Tk or tray event loop still kept Python alive.Impact
Dictation keeps the compatible Ctrl+V workflow while preserving common clipboard content. Quitting from the tray now terminates the process deterministically, including during startup.
Validation
maingit diff --checkpasses