Skip to content

chain-spec: Add validations for epoch and blob parameters#2348

Open
VolodymyrBg wants to merge 7 commits intoberachain:mainfrom
VolodymyrBg:beacon
Open

chain-spec: Add validations for epoch and blob parameters#2348
VolodymyrBg wants to merge 7 commits intoberachain:mainfrom
VolodymyrBg:beacon

Conversation

@VolodymyrBg
Copy link
Copy Markdown

Description:
Add validation checks for critical chain parameters in the chain specification validator:

  • Ensure MinEpochsToInactivityPenalty is greater than zero
  • Ensure SlotsPerEpoch is greater than zero
  • Ensure FieldElementsPerBlob is greater than zero
  • Ensure BytesPerBlob is greater than zero

These validations help prevent invalid chain configurations that could cause issues
during chain operation. The changes improve the robustness of the chain specification
validation by ensuring these fundamental parameters have valid values.

Description:
Add validation checks for critical chain parameters in the chain specification validator:
- Ensure MinEpochsToInactivityPenalty is greater than zero
- Ensure SlotsPerEpoch is greater than zero
- Ensure FieldElementsPerBlob is greater than zero
- Ensure BytesPerBlob is greater than zero

These validations help prevent invalid chain configurations that could cause issues
during chain operation. The changes improve the robustness of the chain specification
validation by ensuring these fundamental parameters have valid values.

Signed-off-by: VolodymyrBg <aqdrgg19@gmail.com>
Signed-off-by: VolodymyrBg <aqdrgg19@gmail.com>
- Ensure MinEpochsToInactivityPenalty is greater than zero
- Ensure SlotsPerEpoch is greater than zero
- Ensure FieldElementsPerBlob is greater than zero
- Ensure BytesPerBlob is greater than zero

Signed-off-by: VolodymyrBg <aqdrgg19@gmail.com>
@VolodymyrBg VolodymyrBg requested a review from a team as a code owner January 11, 2025 18:58
Signed-off-by: VolodymyrBg <aqdrgg19@gmail.com>
Signed-off-by: VolodymyrBg <aqdrgg19@gmail.com>
Signed-off-by: VolodymyrBg <aqdrgg19@gmail.com>
Signed-off-by: VolodymyrBg <aqdrgg19@gmail.com>
@calbera calbera added the os-review Open source contribution to review label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

os-review Open source contribution to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants