-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
bsn: improve docs and add tests #24464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
laundmo
wants to merge
18
commits into
bevyengine:main
Choose a base branch
from
laundmo:bsn-better-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+892
−653
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
006bb16
progress on docs
laundmo 81431d2
further docs filing
laundmo d8b539b
Merge branch 'main' of github.com:bevyengine/bevy
laundmo 085adda
Merge branch 'main' into bsn-better-docs
laundmo fd755c5
Finish initial pass on both lib.rs
laundmo 753395a
update and add trait tags for scenes
laundmo 85564b6
fix typos
laundmo afba143
Merge remote-tracking branch 'origin/main' into bsn-better-docs
laundmo 8f49183
Merge remote-tracking branch 'origin/main' into bsn-better-docs
laundmo b053e2f
Document bsn asset format can be implemented externally
laundmo e93c154
fix macro docs
laundmo 462c533
a lot more docs improvements
laundmo a4c7768
Editorial pass 1
cart 87c3297
Update crates/bevy_scene/macros/src/lib.rs
laundmo 5eed7a1
Update crates/bevy_scene/macros/src/lib.rs
laundmo 36aefdf
Update crates/bevy_scene/macros/src/lib.rs
laundmo 49cc434
Update crates/bevy_scene/macros/src/lib.rs
laundmo c3f6425
Update crates/bevy_scene/macros/src/lib.rs
laundmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is helpful context, but I'm not sure this is the place to drop docs like this. This file is too big to discover something like this. Probably belongs in a "doc contributor guide" or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, i mostly put it in there orignally for myself to copy to render the docs (see the link in the PR). Then i thought yea this could be useful to others. It doesn't even need to be parr of this PR, i'm fine with removing it