feat(infra): agent-runtime → real Core on local kind, verified (GT-438)#180
Conversation
The agent-runtime factory already builds the real HttpCoreEvaluationAdapter when AGENT_RUNTIME_CORE_ENDPOINT is set. Point the local-kind agent-runtime at the in-cluster core-api service so it governs over the REAL stateless Core, not the stub. - evolith-agent-runtime values-local: extraEnv AGENT_RUNTIME_CORE_ENDPOINT (http://evolith-core-api-evolith-core-api/api/v1/evaluate) + CORE_TOKEN + AUDIT_DIR. - Verified in the kind cluster: POST /v1/agent/handle produced a real POST /api/v1/evaluate to core-api (SecurityAudit 200 ALLOW 569ms, from the runtime pod). The real Core rigorously returns 39 findings (GOV-000 etc.) on the empty workspace context — correct behaviour the stub hid; real workspace-context assembly is the next piece. Board: GT-438 → IN-PROGRESS (core-eval real wired + verified on kind). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2fd7ae5692
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # the shared local API key. AGENT_RUNTIME_CORE_ENDPOINT must be the FULL evaluate URL. | ||
| extraEnv: | ||
| AGENT_RUNTIME_CORE_ENDPOINT: "http://evolith-core-api-evolith-core-api/api/v1/evaluate" | ||
| AGENT_RUNTIME_CORE_TOKEN: "local-dev-key" |
There was a problem hiding this comment.
When product/infra/helm/local-test.sh is run with a non-default EVOLITH_API_KEY, the script creates core-api-auth and agent-runtime-auth from that value but installs this chart without overriding AGENT_RUNTIME_CORE_TOKEN; this hardcoded local-dev-key then makes the runtime authenticate successfully on /v1/agent/handle while its internal call to Core /api/v1/evaluate is rejected by Core's API-key guard. Use the same secret/value the local script provisions, or have the script pass this Helm value from $API_KEY.
Useful? React with 👍 / 👎.
1 participant
Apunta el agent-runtime de kind local al Core real del cluster (no el stub). La factory ya construye el
HttpCoreEvaluationAdapterreal cuandoAGENT_RUNTIME_CORE_ENDPOINTestá seteado; este cambio lo setea en elvalues-localhacia el serviciocore-apiin-cluster.Verificado en tu kind
POST /v1/agent/handle→ produjo unPOST /api/v1/evaluatereal al core-api (SecurityAudit 200 ALLOW 569ms, desde el pod del runtime). El runtime gobierna sobre el Core REAL.Hallazgo honesto: el Core real devuelve 39 findings (GOV-000, etc.) sobre el contexto de workspace vacío — comportamiento correcto que el stub ocultaba. La siguiente pieza es ensamblar un contexto de workspace real (trabajo del Tracker).
Board: GT-438 → IN-PROGRESS (core-eval real cableado + verificado en kind). Guard verde.
🤖 Generated with Claude Code