docs(governance): ADR-0111 Quality Signal Provider port + evidence-adapter wave GT-533…537#181
Merged
Conversation
…idence-adapter wave GT-533…537 ADR-0111 fixes the seam through which external quality/evidence tools (Lighthouse, TestSprite, Claude SEO, thermo-nuclear) enrich Evolith Core via adapters and a canonical Evidence model — per-tenant selectable, provenance + determinism mandatory, never a Core dependency. Generalizes the GT-530 ObservabilityEvidence adapter into one uniform seam. Registers the wave on the gap board (EN/ES tracking + catalog): - GT-533 Quality Signal Provider port + Evidence model + per-tenant registry (P1) - GT-534 Lighthouse reference adapter, prototype-first (P1) - GT-535 thermo-nuclear structural-review rubric → code-quality agent + gate (P1) - GT-536 TestSprite test-evidence adapter, opt-in default-off (P2, deferred) - GT-537 GEO/AI-discoverability Scorecards pack, Claude SEO pattern (P3, deferred) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
…al kind Deployed the Tracker (Postgres + BFF + web) into the kind cluster wired to the real Core; POST /api/core/evaluate drove a real core-api /api/v1/evaluate (200 ALLOW from the tracker pod) and persisted a completed CoreEvaluationTransaction. Objetivo 1 governance chain functional end-to-end on kind; only the browser UI check remains. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ding · 4 deferred) The evidence-adapter wave added 3 PENDING + 2 DEFERRED rows; sync the declared Progress/Progreso counters so 08-validate-tracking reconciles (was 532). Guard green locally: 537 gaps validated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d18ee247aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+40
to
+44
| | [`GT-533`](./gap-reference-catalog.md#gt-533) | **[Evidence · ADR-0111] Quality Signal Provider port + canonical `Evidence` model + per-tenant registry.** The seam through which any external quality/evidence tool enriches the Core without becoming a dependency: driven port `IQualitySignalProvider` owned by orchestration (never `core-domain`); Core imports only `Evidence` and receives it inline (like source files via `OverlayFileSystem`, ADR-0080); Core never executes providers; declarative opt-in registry per tenant; mandatory `provenance` + `determinism` flag. Generalizes the GT-530 `ObservabilityEvidence` adapter into one uniform seam. **Prototype first.** | `Evolith Core` | Cross | P1 | L | `PENDING` | | ||
| | [`GT-534`](./gap-reference-catalog.md#gt-534) | **[Evidence adapter · HIGH] Lighthouse reference adapter (Apache-2.0).** Runtime evidence (performance/a11y/SEO, deterministic) behind `IQualitySignalProvider`; the prototype-first proof of the port. OSS, embeddable Node module with JSON output, no lock-in. Needs a companion Node.js Platform ADR for the concrete vendor/runtime choice. | `infra-providers` | Cross | P1 | M | `PENDING` | | ||
| | [`GT-535`](./gap-reference-catalog.md#gt-535) | **[Quality gate · HIGH] Thermo-nuclear structural-review rubric → code-quality agent + Quality Gate.** Adopt the strict structural-review methodology (code-judo, file-size discipline, spaghetti/abstraction/layering checks, severity hierarchy) as a skill for the code-quality-review agent and as the structural-regression criteria of the Quality Gate. Reference methodology, no runtime dependency; respect source attribution/license. | `agent-runtime` | Cross | P1 | M | `PENDING` | | ||
| | [`GT-536`](./gap-reference-catalog.md#gt-536) | **[Evidence adapter · opt-in] TestSprite test-evidence adapter — default OFF.** Optional testing-dimension evidence behind the port; proprietary cloud + credit cost + code egress isolated at the adapter boundary; **never a hard dependency** (opt-in, disabled by default). Reference the discover→plan→generate→execute→heal pipeline for the autonomous remediation agent, without depending on their cloud. | `infra-providers` | Cross | P2 | M | `DEFERRED` | | ||
| | [`GT-537`](./gap-reference-catalog.md#gt-537) | **[Scorecards pack] GEO / AI-discoverability dimension (Claude SEO pattern).** Optional Scorecards pack inspired by the Claude SEO multi-agent audit (score + severity plan); validates that the multi-agent→scorecard pattern scales. Not a Core capability — a product pack in the Portal/Scorecards plane. | `Tracker` | Cross | P3 | L | `DEFERRED` | |
There was a problem hiding this comment.
These five new board rows add 3 PENDING and 2 DEFERRED gaps, but the progress footer still reports the old 503 / 532 ... 9 pending · 2 deferred totals in both EN and ES. The tracking guard parses the table and now expects 537 total, 12 pending, and 4 deferred; node .harness/scripts/ci/08-validate-tracking.mjs fails with EN/ES total, PENDING, and DEFERRED count mismatches, so this documentation change blocks the mandatory tracking validation until the progress lines are updated.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the ADR-0111 decision and the evidence-adapter gap wave to
main(prod).ADR-0111 — Quality Signal Provider port fixes the seam through which external quality/evidence tools (Lighthouse, TestSprite, Claude SEO, thermo-nuclear) enrich Evolith Core via adapters and a canonical
Evidencemodel — per-tenant selectable,provenance+determinismmandatory, never a Core dependency. It generalizes the GT-530ObservabilityEvidenceadapter into one uniform seam and is a Core ADR (agnostic principle: if the four tools disappeared tomorrow, the decision stands).Gap board wave (EN/ES tracking + catalog)
IQualitySignalProviderport +Evidencemodel + per-tenant registryScope
Docs/governance only — no code touched. ADR pair (EN/ES) + ADR registry/matrix + gap-tracking (EN/ES) + gap-reference-catalog (EN/ES).
🤖 Generated with Claude Code