Merge develop→main: GT-516 HXA-03 native fallback + GT-535 skill kind-routing (review follow-ups)#189
Conversation
…GT-516) (#185) HXA-03 ("Infrastructure IMPLEMENTS Core ports") is a POSITIVE/structural assertion. dependency-cruiser is a forbidden-dependency tool and cannot verify a positive "X implements Y" claim, so an enforce block routing HXA-03 through it is semantically wrong: it can only ever degrade to a native fallback or, with a from/to config, emit false positives. Per GT-516's own design (and closure note), HXA-03 takes the documented per-rule NATIVE path rather than an enforce block (HXA-06 keeps its enforce block, which already degrades to a native fallback). - Remove the enforce block from HXA-03 so it evaluates on the NativeEvaluator path. - Update the ADR-0002 pilot test: enforcer-routed = HXA-01/02/04/05/06/07 (6); compiled = HXA-01/02/04/05/07 (5, unchanged); fallback = HXA-06 (1). Low-risk: GT-516's real cross-runtime execution is GT-512-gated, so nothing runs this enforce block live yet. Verified core-domain green (npx tsc && npx jest: 1018 passing) on this exact change. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…ence' kind (GT-535) (#184) The `code-quality-structural-review` skill declared `evaluationKinds: ['code-quality']`, but 'code-quality' is a quality-signal DIMENSION (the tag on the Evidence StructuralReviewProvider emits), NOT a member of the core-domain `EvaluationKind` union. `buildEvaluationContext` filters declared kinds against a KNOWN_KINDS allowlist, so 'code-quality' was silently dropped and the context fell back to `['gate']` — the skill was declared but never routed as the quality-signal evaluation it is, leaving the GT-535 provider unreachable. Fix (map onto an existing supported kind, not forge a phantom one): - default-skills.ts: `evaluationKinds: ['code-quality']` -> `['evidence']`, the canonical kind for declared quality-signal Evidence (ADR-0111 / GT-533). The 'code-quality' dimension stays where it belongs — on the emitted Evidence. - context-mapper.ts: sync the KNOWN_KINDS allowlist to the full canonical `EvaluationKind` union (add 'design', 'phase-artifacts') with a maintenance note, so the same "declared-but-dropped" class can't recur for those kinds. - structural-review.spec.ts: add a routing guard proving the skill forwards 'evidence' through buildEvaluationContext (not the 'gate' fallback), and that a dimension-shaped kind still collapses to ['gate']. Kind routing only; the concrete IStructuralReviewer LLM adapter is a separate follow-on. agent-runtime jest green (17 suites / 121 tests), tsc --noEmit clean. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4fc4ad04e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "toolRuleId": "hxa-03-infra-implements-ports", | ||
| "runtime": "node" | ||
| } | ||
| "layer": "Infrastructure" |
There was a problem hiding this comment.
When ADR-0002 is evaluated through the Native/Composite engine, HXA-03 now has no enforce block, so it is routed to NativeEvaluator; however, I checked ArchitectureRuleHandler/STRUCTURAL_CATEGORIES and layer-structure is not handled, and a repo-wide search shows no native HXA-03 implementation. Skipped native results are filtered out of validation issues, so a satellite whose infrastructure does not implement Core ports can pass without any blocking finding. Please add the native HXA-03 logic (or keep an actually evaluated fallback path) before removing this enforcement block.
Useful? React with 👍 / 👎.
1 participant
Two review-follow-up fixes that landed on develop after PR #188, plus the GT-451 CLI prepack hygiene:
enforceblock (HXA-03 is a positive "infrastructure implements ports" rule that a forbidden-dependency tool cannot verify → would false-positive). Restores the intended native fallback + corrected round-trip partition.evidenceevaluation kind so the skill is actually reachable at runtime (was declaring an unroutedcode-qualitykind).prepackdropsdist/.tsbuildinfofrom the published CLI tarball (build-cache hygiene).Both follow-ups were flagged during the PR #183 review and fixed in separate sessions; all required checks pass on develop.
🤖 Generated with Claude Code