Skip to content

Feature/adjacency metric#94

Open
wvjgsuhp wants to merge 8 commits into
mainfrom
feature/adjacency-metric
Open

Feature/adjacency metric#94
wvjgsuhp wants to merge 8 commits into
mainfrom
feature/adjacency-metric

Conversation

@wvjgsuhp
Copy link
Copy Markdown
Contributor

@wvjgsuhp wvjgsuhp commented May 7, 2026

algorithm

  1. create a list of lists of offsets according to rings provided
  2. generate padded matrices from the list
  3. score

wvjgsuhp and others added 6 commits May 7, 2026 16:53
- Move calculate_adjacency_score into R/calculate_adjacency_score.R alongside
  new adjacency_score_vec / ring_offsets / shift_pad helpers
- Add ring_dists, ring_weights, ring_type args (defaults preserve old behaviour)
- objective_function forwards ring_* args from ... so they reach the SA path
- Cover ring offsets, shift padding, per-ring weighting, and end-to-end speed()
  integration in tests

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Note adjacency ring args in NEWS
- Ignore stray Rplots.pdf

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dx now shifts columns (x-axis) and dy now shifts rows (y-axis), aligning
with conventional usage. Ring offsets and the shift_pad test follow.
Behaviour unchanged because rings are symmetric in dx/dy.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@wvjgsuhp wvjgsuhp linked an issue May 7, 2026 that may be closed by this pull request
@wvjgsuhp wvjgsuhp requested a review from rogerssam May 7, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update adjacency to account for more than just immediate neighbours

1 participant