feat: SQL, GraphQL, and Protobuf component extraction#31
Open
bionicles wants to merge 1 commit into
Open
Conversation
Line-oriented ports of legacy parse_sql / parse_graphql / parse_grpc in extract/simple.rs: - SQL: CREATE TABLE statements (dotall regex), body lines re-emitted under a 3-space indent; - GraphQL: type/enum headers sans brace, other non-comment lines indented, bare closing braces skipped; - Protobuf: syntax/service/message/rpc lines plus '='-bearing field lines with field numbers kept. All three fixture component sets match the legacy goldens byte-for-byte (.sql/.graphql/.proto added to v1 parity scope); trees_v1 goldens regenerated with those parsers unstubbed; robustness garbage-input coverage extended to the three extensions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 3 of the post-port roadmap: the cheap, popular line formats.
What
Line-oriented ports of legacy
parse_sql/parse_graphql/parse_grpcinextract/simple.rs(the home of the other line formats):.sql):CREATE TABLE name (body);statements via a dotall regex; body lines re-emitted under a 3-space indent..graphql):type/enumheaders without the trailing brace; every other non-comment line indented; bare}lines skipped..proto):syntax/service/message/rpclines plus=-bearing field lines (field numbers kept,;tail dropped).Acceptance
sql_test.sql,test.graphql,test.protocomponent sets match the legacy goldens byte-for-byte; extensions added to the v1 parity scope ingolden_parity.rs.trees_v1goldens regenerated with the three parsers unstubbed; all 13 tree-render parity tests pass..sql/.graphql/.proto.-D warningsclean, fmt clean.Note: independent of #29 and #30 (branched from main); expect a trivial dispatch-table conflict with #29 on merge, whichever lands second.
🤖 Generated with Claude Code