[pull] develop from smartcontractkit:develop#442
Merged
Conversation
* Verify Workflow DON authorization at relay DON (PRIV-433) The relay DON now verifies a secrets request beyond attestation: the enclave forwards the F+1 Workflow-DON-signed compute requests, whose PublicData names the authorized owner and workflow. verifyWorkflowAuthorization reconstructs the shared ComputeRequest hash, verifies the signatures against the onchain Workflow DON signer set (2*F+1 quorum, matching the enclave), and confirms the owner and workflow match the request. A compromised TEE passes attestation but cannot forge a Workflow DON quorum over a different owner. Bumps chainlink-common to the vendored-SignedComputeRequest types (#2109). Test fixtures gain EnclaveConfig to satisfy the strict validation pulled in by the bump (PRIV-458). * Address Copilot review on relay DON authorization Fetch LocalNode once in handleSecretsGet and pass WorkflowDON into verifyWorkflowAuthorization. A registry failure now stays ErrInternal instead of being misclassified as a client ErrInvalidParams, and the duplicate registry call is removed. The verifier's errors are all client errors by construction. Align comments to the 2*F+1 quorum the code enforces (was inconsistently described as F+1). * Clarify LocalNode fetch comment in handleSecretsGet * make gomodtidy: propagate chainlink-common bump to sibling modules Tidy core/scripts, deployment, integration-tests(/load), and system-tests (lib/tests) so their chainlink-common and chainlink-protos/cre versions match the root after the #2109 rebump. Fixes the Clean Go Tidy & Generate CI check. * fix(confidentialrelay): resolve golangci-lint findings The develop merge brought a stricter lint config that flagged existing code: - reuse the outer err instead of shadowing it in the workflow-auth check (govet shadow) - drop the embedded ComputeRequest field from the Hash() selector (staticcheck QF1008)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )