Skip to content

test: add coverage for unknown value to -blockfilterindex - #25192

Merged
maflcko merged 1 commit into
bitcoin:masterfrom
brunoerg:2022-05-unknown-blockfilter
May 25, 2022
Merged

test: add coverage for unknown value to -blockfilterindex#25192
maflcko merged 1 commit into
bitcoin:masterfrom
brunoerg:2022-05-unknown-blockfilter

Conversation

@brunoerg

Copy link
Copy Markdown
Contributor

This PR adds test coverage for the following init error:

return InitError(strprintf(_("Unknown -blockfilterindex value %s."), name));

Passing an unknown value to -blockfilterindex should throw an error.

@DrahtBot

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #25193 (indexes: Read the locator's top block during init, allow interaction with reindex-chainstate by mzumsande)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot added the Tests label May 23, 2022

@dunxen dunxen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cr-ACK 295ff61

@maflcko
maflcko merged commit 8c721ff into bitcoin:master May 25, 2022
@bitcoin bitcoin locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants