Skip to content

use regex-lite as regex implementation#372

Closed
snowp wants to merge 4 commits into
mainfrom
try-regex-lite
Closed

use regex-lite as regex implementation#372
snowp wants to merge 4 commits into
mainfrom
try-regex-lite

Conversation

@snowp
Copy link
Copy Markdown
Contributor

@snowp snowp commented May 13, 2025

@FranAguilera FranAguilera reopened this May 13, 2025
@bitdriftlabs bitdriftlabs deleted a comment from github-actions Bot May 13, 2025
@bitdriftlabs bitdriftlabs deleted a comment from github-actions Bot May 13, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2025
@bitdriftlabs bitdriftlabs unlocked this conversation May 13, 2025
@bitdriftlabs bitdriftlabs deleted a comment from github-actions Bot May 13, 2025
@FranAguilera FranAguilera reopened this May 13, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2025
@bitdriftlabs bitdriftlabs unlocked this conversation May 13, 2025
@FranAguilera FranAguilera self-requested a review May 13, 2025 13:46
@FranAguilera FranAguilera force-pushed the try-regex-lite branch 2 times, most recently from 11af059 to 8ad02cb Compare May 14, 2025 13:28
@bitdriftlabs bitdriftlabs deleted a comment from github-actions Bot May 14, 2025
@github-actions
Copy link
Copy Markdown

📦 APK Size Report

Metric Size (KB)
Baseline 3631
Current 3207
Difference -424

✅ APK size decreased by 424 KB.

@murki
Copy link
Copy Markdown
Contributor

murki commented May 14, 2025

by manually running the tools/capture_so_size.sh on both branches I get values of

main:
  inflating: AndroidManifest.xml     
   creating: /private/tmp/bitdrift_so/META-INF
 extracting: META-INF/MANIFEST.MF    
  inflating: classes.jar             
   creating: /private/tmp/bitdrift_so/jni
   creating: /private/tmp/bitdrift_so/jni/arm64-v8a
  inflating: jni/arm64-v8a/libcapture.so  
  inflating: proguard.txt            
  inflating: resources.arsc          
  adding: jni/arm64-v8a/libcapture.so (deflated 60%)
1224	aar.zip

vs

try-regex-lite:
  inflating: AndroidManifest.xml     
   creating: /private/tmp/bitdrift_so/META-INF
 extracting: META-INF/MANIFEST.MF    
  inflating: classes.jar             
   creating: /private/tmp/bitdrift_so/jni
   creating: /private/tmp/bitdrift_so/jni/arm64-v8a
  inflating: jni/arm64-v8a/libcapture.so  
  inflating: proguard.txt            
  inflating: resources.arsc          
  adding: jni/arm64-v8a/libcapture.so (deflated 58%)
868	aar.zip

which nets a difference of -356 KB, just for comparison. cc @FranAguilera

📦 APK Size Report

Metric Size (KB)
Baseline 3631
Current 3207
Difference -424

✅ APK size decreased by 424 KB.

@FranAguilera
Copy link
Copy Markdown
Contributor

by manually running the tools/capture_so_size.sh on both branches I get values of

main:
  inflating: AndroidManifest.xml     
   creating: /private/tmp/bitdrift_so/META-INF
 extracting: META-INF/MANIFEST.MF    
  inflating: classes.jar             
   creating: /private/tmp/bitdrift_so/jni
   creating: /private/tmp/bitdrift_so/jni/arm64-v8a
  inflating: jni/arm64-v8a/libcapture.so  
  inflating: proguard.txt            
  inflating: resources.arsc          
  adding: jni/arm64-v8a/libcapture.so (deflated 60%)
1224	aar.zip

vs

try-regex-lite:
  inflating: AndroidManifest.xml     
   creating: /private/tmp/bitdrift_so/META-INF
 extracting: META-INF/MANIFEST.MF    
  inflating: classes.jar             
   creating: /private/tmp/bitdrift_so/jni
   creating: /private/tmp/bitdrift_so/jni/arm64-v8a
  inflating: jni/arm64-v8a/libcapture.so  
  inflating: proguard.txt            
  inflating: resources.arsc          
  adding: jni/arm64-v8a/libcapture.so (deflated 58%)
868	aar.zip

which nets a difference of -356 KB, just for comparison. cc @FranAguilera

📦 APK Size Report

Metric Size (KB)
Baseline 3631
Current 3207
Difference -424

✅ APK size decreased by 424 KB.

thanks @murki . I'm actually working on this aar logic but I need to polish it more #378

@snowp snowp changed the title no-more-regex use regex-lite as regex implementation Oct 15, 2025
@FranAguilera
Copy link
Copy Markdown
Contributor

Closing in favor of #960

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants