Skip to content

PM-39349: feat: Update Plan Screen#7155

Open
david-livefront wants to merge 1 commit into
mainfrom
PM-39349-plan-screen-update
Open

PM-39349: feat: Update Plan Screen#7155
david-livefront wants to merge 1 commit into
mainfrom
PM-39349-plan-screen-update

Conversation

@david-livefront

@david-livefront david-livefront commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-39349

📔 Objective

This PR updates the Plan Screen for Free Users.

📸 Screenshots

Before After

@david-livefront david-livefront requested a review from a team as a code owner July 10, 2026 15:11
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the Plan Screen redesign for free users (PM-39349). The change restructures PremiumDetailsCard into an illustration + benefits list, adds a gradient card background for non-dynamic themes, introduces an isDynamicTheme flag on BitwardenColorScheme, and updates the price/CTA copy. Unit tests were updated to match the new strings and scroll behavior, and drawable assets are provided across all density buckets (light and night).

Code Review Details

No blocking findings.

Notes verified during review:

  • The new isDynamicTheme field has no default value, so the compiler forces all three BitwardenColorScheme construction sites (dark, light, dynamic) to be updated — all are correctly set.
  • The removed strings (per_month, upgrade_now, youll_go_to_stripes_secure_checkout...) are no longer referenced in Kotlin; remaining occurrences live only in Crowdin-managed values-* translation files, which is expected.
  • img_premium and bg_card_gradient are supplied for both light and night variants across all densities.
  • PlanScreenTest assertions align with the new copy and the added performScrollTo() calls.

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.90244% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.85%. Comparing base (36c892e) to head (4b259fa).

Files with missing lines Patch % Lines
...den/ui/platform/feature/premium/plan/PlanScreen.kt 95.06% 2 Missing and 2 partials ⚠️
.../ui/platform/feature/premium/plan/PlanViewModel.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7155      +/-   ##
==========================================
- Coverage   85.89%   85.85%   -0.04%     
==========================================
  Files         927      885      -42     
  Lines       66232    64731    -1501     
  Branches     9640     9599      -41     
==========================================
- Hits        56892    55578    -1314     
+ Misses       5887     5708     -179     
+ Partials     3453     3445       -8     
Flag Coverage Δ
app-data 17.63% <0.00%> (+0.32%) ⬆️
app-ui-auth-tools 18.79% <0.00%> (+0.12%) ⬆️
app-ui-platform 16.51% <93.90%> (-0.33%) ⬇️
app-ui-vault 27.47% <0.00%> (-0.60%) ⬇️
authenticator 6.12% <0.00%> (-0.02%) ⬇️
lib-core-network-bridge 4.03% <0.00%> (-0.02%) ⬇️
lib-data-ui 1.14% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant