Add getLivePlayStoreVersion Fastlane lane#7156
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the new Code Review DetailsNo blocking findings. The lane follows the credentials-selection and Supply-client patterns already present in the codebase. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7156 +/- ##
=======================================
Coverage 85.89% 85.89%
=======================================
Files 927 927
Lines 66232 66232
Branches 9640 9640
=======================================
Hits 56892 56892
Misses 5887 5887
Partials 3453 3453
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This lane checks for actually published (status 'completed') versions on Google Play rather than just approved versions. With managed publishing enabled, versions can be approved but not yet published to users.
AmyLGalles
force-pushed
the
agalles/add-get-live-play-store-version-lane
branch
from
ceb23e2 to
e0fd578
Compare
The previous implementation incorrectly called client.track_version_codes which returns an Array, not a Track object with .releases. Changes: - Use client.tracks(track) to get Track objects - Wrap in begin_edit/abort_current_edit as required by Supply client - Access releases directly from track_obj.releases - Get version name directly from completed_release.name instead of parallel array lookup This fixes the NoMethodError that would occur at runtime when trying to call .releases on an Array.
2 participants
Summary
Add a new Fastlane lane
getLivePlayStoreVersionthat checks for actually published (status 'completed') versions on Google Play rather than just approved versions.Background
With managed publishing enabled in Google Play, versions can be approved but not yet published to users. The existing
getLatestPlayStoreVersionlane returns any version on the specified track, regardless of whether it's actually live.Changes
getLivePlayStoreVersionlane tofastlane/FastfilegetLatestPlayStoreVersionfor compatibilityRelated PRs
Testing
Tested by verifying the lane checks for
status == "completed"in the Google Play release data.Type of change