[PM-35111] feat: Add FedRAMP (bitwarden-gov.com) entry to region selector#2857
Open
fedemkr wants to merge 5 commits into
Open
[PM-35111] feat: Add FedRAMP (bitwarden-gov.com) entry to region selector#2857fedemkr wants to merge 5 commits into
fedemkr wants to merge 5 commits into
Conversation
… selector Adds a `.gov` RegionType case backed by bitwarden-gov.com default URLs so users can select the new government cloud environment from the region selector, ahead of the broader FedRAMP support work tracked in PM-35110.
# Conflicts: # BitwardenKit/Core/Platform/Models/Domain/EnvironmentURLData.swift # BitwardenKit/Core/Platform/Models/Domain/EnvironmentURLs.swift # BitwardenShared/Core/Platform/Models/Enum/RegionType.swift # BitwardenShared/Core/Platform/Models/Enum/RegionTypeTests.swift # BitwardenShared/Core/Platform/Services/EnvironmentService.swift # BitwardenShared/UI/Auth/Utilities/RegionHelper.swift
github-actions
Bot
added
app:password-manager
| let environmentURLData: EnvironmentURLData = switch environmentURLData.region { | ||
| case .europe: .defaultEU | ||
| case .unitedStates: .defaultUS | ||
| case .gov: .defaultGov |
Contributor
There was a problem hiding this comment.
🤔 Should these be alphabetized?
| @@ -0,0 +1,75 @@ | |||
| import XCTest | |||
Contributor
There was a problem hiding this comment.
🎨 If we're making a new test file, would it make sense to make it Swift Testing?
| @testable import BitwardenKit | ||
|
|
||
| class EnvironmentURLsTests: BitwardenTestCase { | ||
| class EnvironmentURLsTests: BitwardenTestCase { // swiftlint:disable:this type_body_length |
Contributor
There was a problem hiding this comment.
🤔 Is this getting rid of a pre-existing warning?
| @testable import BitwardenShared | ||
| @testable import BitwardenSharedMocks | ||
|
|
||
| extension EnvironmentServiceTests { |
Contributor
There was a problem hiding this comment.
🎨 Could we make these tests Swift Testing?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2857 +/- ##
===========================================
- Coverage 81.27% 40.60% -40.68%
===========================================
Files 1027 357 -670
Lines 66109 16664 -49445
===========================================
- Hits 53733 6767 -46966
+ Misses 12376 9897 -2479 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-35111
📔 Objective
Adds a
.govRegionType case backed by bitwarden-gov.com default URLs so users can select the new government cloud environment from the region selector.📸 Screenshots