llm: Add Step 7 verify/lint/format section to implementing-ios-code skill#2859
llm: Add Step 7 verify/lint/format section to implementing-ios-code skill#2859KatherineInCode wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
t:llm
|
Claude Code is reviewing this pull request... If this comment does not update with results, check the Actions log. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
==========================================
- Coverage 81.25% 78.98% -2.27%
==========================================
Files 1027 1150 +123
Lines 66091 73404 +7313
==========================================
+ Hits 53699 57977 +4278
- Misses 12392 15427 +3035 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| Exceptions: protocol property/function implementations (docs live in the protocol), mock classes. | ||
| Use pragma marks to organize code. `// MARK: -` is used to denote different objects in the same file; `// MARK:` is used to denote different sections within an object. | ||
|
|
||
| ## Step 7: Verify — Lint, Format, and Regenerate |
There was a problem hiding this comment.
🤔 Should we call the same scripts that we call in the pre-commit hook instead? or combine script calls with some Claude prompts? so we can centralize at least a part of this.
There was a problem hiding this comment.
I have it now just literally calling the pre-commit hooks, which hopefully centralizes things a little better 🤔
andrebispo5
left a comment
andrebispo5
left a comment
There was a problem hiding this comment.
Looks good now with the pre-commit script usage 👍
4 participants
🎟️ Tracking
📔 Objective
Adds a "Step 7: Verify — Lint, Format, and Regenerate" section to the
implementing-ios-codeskill. This makes the post-implementation verification step explicit and actionable:swiftlint,swiftformat --lint --lenient, andtyposcommandsline_length,file_length,type_body_length)Without this step, implementations were sometimes handed back with lint or format violations, or with missing SwiftGen output after adding localization strings — requiring a follow-up round of corrections. Making verification explicit and placing it before the handoff point means violations get caught and fixed in the same session, not discovered during preflight or review.