Skip to content

[PM-40043] chore: Exclude .build and .claude folders from lint#2860

Open
fedemkr wants to merge 1 commit into
mainfrom
PM-40043/exclude-build-claude-lint
Open

[PM-40043] chore: Exclude .build and .claude folders from lint#2860
fedemkr wants to merge 1 commit into
mainfrom
PM-40043/exclude-build-claude-lint

Conversation

@fedemkr

@fedemkr fedemkr commented Jul 6, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

PM-40043

📔 Objective

Exclude .build and .claude folders from Swift lint as it can cause problems when working with worktrees inside the .claude folder.
Particularly, if one has a corktree in the .claude folder and wants to compile from the main repo (not the worktree) then Swift lint will try to make it pass inside the .claude folder's worktree causing a lot of errors to appear. So in order for this not to happen we can just exclude such folders.

…e problems compiling from the main repo when it has worktrees.
@fedemkr fedemkr requested review from a team and matt-livefront as code owners July 6, 2026 21:09
@fedemkr fedemkr changed the title [PM-40043] Exclude .build and .claude folders from lint [PM-40043] chore: Exclude .build and .claude folders from lint Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the single change to .swiftlint.yml, which adds .build and .claude to the excluded list. The change is scoped, uses valid SwiftLint syntax consistent with existing entries (build, vendor/bundle), and correctly addresses the described problem of worktrees inside .claude causing spurious lint errors when compiling from the main repo. No security, correctness, or breaking-change concerns.

Code Review Details

No findings. The configuration change is correct and well-scoped.

@fedemkr fedemkr added the t:tech-debt Change Type - Tech debt label Jul 6, 2026
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.96%. Comparing base (72273fe) to head (1a0472f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
- Coverage   81.25%   78.96%   -2.29%     
==========================================
  Files        1027     1150     +123     
  Lines       66091    73386    +7295     
==========================================
+ Hits        53699    57950    +4251     
- Misses      12392    15436    +3044     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront

Copy link
Copy Markdown
Collaborator

❓ Should SwiftFormat get the same exclusions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants