Skip to content

ci: Test verbose upload to TestFlight#2864

Open
fedemkr wants to merge 1 commit into
mainfrom
upload-testflight-verbose
Open

ci: Test verbose upload to TestFlight#2864
fedemkr wants to merge 1 commit into
mainfrom
upload-testflight-verbose

Conversation

@fedemkr

@fedemkr fedemkr commented Jul 7, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

📔 Objective

Add --verbose flag to upload to TestFlight to help diagnosis.

@fedemkr fedemkr requested a review from a team as a code owner July 7, 2026 16:38
@github-actions github-actions Bot added the t:ci Change Type - Updates to automated workflows label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: REQUEST CHANGES

This PR adds a --verbose flag to the xcrun altool TestFlight upload step in .github/workflows/_build-any.yml to aid diagnosis. The change is small and CI-only, but it introduces a shell syntax error in the modified line.

Code Review Details
  • ❌ : Malformed line continuation (\ \) passes a stray argument to altool, breaking the upload command
    • .github/workflows/_build-any.yml:304

ALTOOL_OUTPUT=$(xcrun altool --upload-app \
--type ios \
--file "$_EXPORT_FILEPATH" \
--file "$_EXPORT_FILEPATH" \ \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL: Malformed line continuation breaks the TestFlight upload command.

Details and fix

The line ends with \ \ (backslash-space-backslash). Only the final backslash is a valid line continuation. The first \ is an escaped space, which the shell passes to altool as a stray standalone argument between --file "$_EXPORT_FILEPATH" and --verbose. altool will reject the unexpected argument and the upload step will fail.

Suggested change
--file "$_EXPORT_FILEPATH" \ \
--file "$_EXPORT_FILEPATH" \
--verbose \

The correct single-backslash form is used in the analogous upload step at line 268.

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.02%. Comparing base (5569548) to head (2c5c1dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
- Coverage   81.28%   79.02%   -2.27%     
==========================================
  Files        1027     1150     +123     
  Lines       66123    73418    +7295     
==========================================
+ Hits        53748    58016    +4268     
- Misses      12375    15402    +3027     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant