ci: Test verbose upload to TestFlight#2864
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: REQUEST CHANGES This PR adds a Code Review Details
|
| ALTOOL_OUTPUT=$(xcrun altool --upload-app \ | ||
| --type ios \ | ||
| --file "$_EXPORT_FILEPATH" \ | ||
| --file "$_EXPORT_FILEPATH" \ \ |
There was a problem hiding this comment.
❌ CRITICAL: Malformed line continuation breaks the TestFlight upload command.
Details and fix
The line ends with \ \ (backslash-space-backslash). Only the final backslash is a valid line continuation. The first \ is an escaped space, which the shell passes to altool as a stray standalone argument between --file "$_EXPORT_FILEPATH" and --verbose. altool will reject the unexpected argument and the upload step will fail.
| --file "$_EXPORT_FILEPATH" \ \ | |
| --file "$_EXPORT_FILEPATH" \ | |
| --verbose \ |
The correct single-backslash form is used in the analogous upload step at line 268.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2864 +/- ##
==========================================
- Coverage 81.28% 79.02% -2.27%
==========================================
Files 1027 1150 +123
Lines 66123 73418 +7295
==========================================
+ Hits 53748 58016 +4268
- Misses 12375 15402 +3027 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
📔 Objective
Add
--verboseflag to upload to TestFlight to help diagnosis.