[PM-37864] feat: Hide create account button based on server disableUserRegistration config

[fedemkr]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-37864

📔 Objective

Adds a settings.disableUserRegistration field to ConfigResponseModel and the ServerConfig domain model, populated from the server's /config response.

The landing processor subscribes to configPublisher in init and reactively updates LandingState.isCreateAccountButtonHidden whenever a pre-auth config is emitted. The "New around here? Create account" row in LandingView is removed from the view hierarchy entirely when the flag is true.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of settings.disableUserRegistration to ConfigResponseModel/ServerConfig, the reactive hiding of the "Create account" row in LandingView via a configPublisher subscription in LandingProcessor, and the new .gov (FedRAMP) RegionType with its environment URLs. The new region cases are handled exhaustively across all switch statements and are well covered by tests. One non-blocking lifecycle concern noted on the processor subscription.

Code Review Details

• ⚠️ : Task in init strongly captures self over a never-completing publisher, leaking the screen-scoped processor
  • BitwardenShared/UI/Auth/Landing/LandingProcessor.swift:62

[codecov]

Codecov Report

❌ Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.57%. Comparing base (85f3884) to head (a94616c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...Kit/Core/Platform/Models/Domain/ServerConfig.swift	0.00%	7 Missing ⚠️
...rm/Services/API/Response/ConfigResponseModel.swift	0.00%	4 Missing ⚠️
...re/Platform/Models/Domain/EnvironmentURLData.swift	71.42%	2 Missing ⚠️
...rdenKit/Core/Platform/Models/Enum/RegionType.swift	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2865       +/-   ##
===========================================
- Coverage   81.27%   40.57%   -40.71%     
===========================================
  Files        1027      357      -670     
  Lines       66109    16675    -49434     
===========================================
- Hits        53733     6766    -46967     
+ Misses      12376     9909     -2467     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[claude]

⚠️ IMPORTANT: This Task strongly captures self, leaking the processor.

Details and fix

configPublisher() is backed by a Never-failing subject that never completes, so this for await loop runs indefinitely and the Task retains self (the LandingProcessor) for the lifetime of the app. When the landing screen is dismissed, the processor cannot deallocate.

Unlike ClientService / ServerCommunicationConfigClientSingleton (which use this pattern but are app-lifetime singletons where the retain is harmless), a StateProcessor is screen-scoped and expected to deallocate. Other processors that hold long-lived tasks use [weak self] (e.g. VaultListProcessor, AppProcessor).

Task { [weak self] in
    guard let configPublisher = await self?.services.configService.configPublisher() else { return }
    for await metaConfig in configPublisher {
        guard metaConfig?.isPreAuth == true else { continue }
        self?.state.isCreateAccountButtonHidden = metaConfig?.serverConfig?
            .settings?.disableUserRegistration == true
    }
}