[PM-40262] Complete Device Auth Key core support#2878
Closed
2001Y wants to merge 1 commit into
Closed
Conversation
|
|
Collaborator
|
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
Author
|
Closing this premature test-only draft while coordinating with the existing Device Auth Key work in #2423. Local implementation and validation will continue before any new public PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current state
This draft currently contains the first TDD specification only. The expected RED is
DeviceAuthKeyError.notImplemented; implementation commits will follow after that behavior is confirmed in CI.This continues the core-service direction explored in #2423 without cherry-picking its conflicting branch.
Test plan
DeviceAuthKeyServiceTestspassBitwardenSharedgeneric simulator build passes