Fix for issues in ListView#1
Open
bleze wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: Double-clicking an item calls doubleClicked(item) → onEdit() → navigateTo() → currentPage.reset(), which destroys the Page and the ListView itself. Back in onItemClick, this is dangling — any access (e.g. this->activated) crashes with "memory access out of bounds".
Three changes in ListView.cpp:
~ListView() — clears selectionChanged before root.reset(). Without this, when pin finally releases the ListView after onItemClick finishes, item removal calls selectItem(nullptr) → selectionChanged() → updateButtons() on the already-destroyed ListPage.
onItemClick — auto pin = shared_from_this() keeps the ListView alive for the duration of the handler, so this->activated (and anything else after doubleClicked returns) is safe to access.
onBodyKeyDown — same guard for the Enter-key path that calls activated(item), which has the identical lifetime hazard.