Remove stale mosh1 hint from mosh's error message#2269
Open
alvarofranz wants to merge 1 commit into
Open
Conversation
mosh1 was removed, but mosh still tells users to "Use mosh1 for the deprecated (previous) mosh version." when a connection fails. Drop that line so the error no longer references a command that's gone. Fixes blinksh#2254
Member
|
Thanks for all these fixes @alvarofranz!! I will start merging now. Is there any reason why you closed all of them? |
Author
|
@carloscabanero I noticed the project is kinda stale and there are many things I want to change in a different direction. So started a fresh fork with many breaking changes without having to break or drastically change what you already built here. But if you are interested we can coordinate, I can share my vision if you like! Thanks Carlos! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a tiny error-message fix:
mosh1has since been removed, so this points users at a command that no longer exists. Reported in #2254 and confirmed by @carloscabanero in the thread:This drops that single line from
mosh'sdie(), so a failed connection no longer references the removed command. No other behavior changes.Fixes #2254